New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file read windows #47876

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
3 participants
@doesitblend
Contributor

doesitblend commented May 29, 2018

What does this PR do?

Adds the file.read function to the win_file.py module

Related Issue

#45520

Previous Behavior

[root@localhost]# salt '*' file.read "C:\\salt\\conf\\minion"
win2016-2:
    ----------
    file.read:
        'file.read' is not available.

New Behavior

[root@localhost _modules]# salt '*' myfile.read "C:\\salt\\conf\\minion"
win2016-2:
    master: 192.168.60.10
    log_level_logfile: debug
    startup_states: highstate

Tests written?

No

Commits signed with GPG?

No

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows May 29, 2018

@doesitblend doesitblend requested review from rallytime and twangboy May 29, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented May 29, 2018

I'm probably not the right person to review this one, so I've removed my review request. :)

@rallytime rallytime removed their request for review May 29, 2018

@@ -30,13 +30,14 @@
import re # do not remove, used in imported file.py functions
import string # do not remove, used in imported file.py functions
import sys # do not remove, used in imported file.py functions
import io # do not remove, used in imported file.py functions
import fileinput # do not remove, used in imported file.py functions

This comment has been minimized.

@twangboy

twangboy May 29, 2018

Contributor

Please add back import io

@doesitblend doesitblend force-pushed the doesitblend:add-file-read-windows branch from 1522f5e to 3f7e7ec May 29, 2018

@doesitblend doesitblend requested a review from saltstack/team-core as a code owner May 29, 2018

@doesitblend doesitblend changed the base branch from 2018.3 to 2017.7 May 29, 2018

@rallytime rallytime merged commit b9da4f1 into saltstack:2017.7 May 30, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10321 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19407 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25547 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17623 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5351 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23285 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22252 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment