New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows tests suite breakage #47917

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented Jun 1, 2018

What does this PR do?

Fix runtests.py for windows builds. This broke in PR #47500

Previous Behavior

#47500 started including the domain with the username which broke the test suite.

New Behavior

Still use centralized current username lookup but do not include the domain by default in the tests.support.helpers.this_user function. This gets the windows test suite running and reporting results.

Tests written?

No - Fixes existing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from gtmanfred Jun 1, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Jun 1, 2018

@dwoz dwoz requested a review from twangboy Jun 1, 2018

@gtmanfred gtmanfred merged commit 735e920 into saltstack:2017.7 Jun 1, 2018

5 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5415 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10388 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19471 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25612 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17683 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23349 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22313 — SUCCESS
Details

@dwoz dwoz deleted the dwoz:winsuite branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment