New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_pkg: pkg.refresh_db verbose=True PY3 compatibility fix #47922

Merged
merged 3 commits into from Jun 5, 2018

Conversation

Projects
None yet
4 participants
@damon-atkins
Member

damon-atkins commented Jun 1, 2018

What does this PR do?

pkg.refresh_db verbose=True under python 3 should return a list instead of objects; under python 2 returned a list

What issues does this PR fix or reference?

None Raised.

Previous Behavior

PY3

successful_list: {
    "salt-winrepo-ng\\grepwin.sls":
        "odict_keys(['grepwin'])",
etc

PY2

successful_list: {
    "salt-winrepo-ng\\grepwin.sls": [
        "grepwin"
    ], 
etc

New Behavior

PY3 now returns the same as PY2.

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested review from saltstack/team-windows Jun 1, 2018

@isbm

isbm approved these changes Jun 2, 2018

damon-atkins added some commits Jun 3, 2018

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented Jun 4, 2018

Please review @team-windows

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented Jun 4, 2018

Please review @saltstack/team-windows

@rallytime rallytime merged commit 3e91a31 into saltstack:2017.7 Jun 5, 2018

7 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19530 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25672 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17741 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5474 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23407 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10446 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22372 — SUCCESS
Details

@damon-atkins damon-atkins deleted the damon-atkins:2017.7_win_pkg_keys_fix branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment