New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exceptions in git import for salt.utils.gitfs #47924

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
3 participants
@Ch3LL
Contributor

Ch3LL commented Jun 1, 2018

What does this PR do?

Makes sure we catch all exceptions when attempting to import salt due to an upstream bug here: gitpython-developers/GitPython#762 This will workaround the upstream issue to ensure we aren't stack tracing when attempting to import git.

What issues does this PR fix or reference?

#47905 (comment)

@rallytime rallytime merged commit 58b5f2b into saltstack:2018.3 Jun 1, 2018

5 of 9 checks passed

default Pull Requests » Salt PR - Main Build - PY2/PY3 #9168
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5426 — ABORTED
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10399 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19482 — ABORTED
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25623 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17694 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23360 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22324 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment