New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.8] Ensure x509 passphrase is a string #47957

Merged
merged 2 commits into from Jun 5, 2018

Conversation

Projects
None yet
2 participants
@garethgreenaway
Member

garethgreenaway commented Jun 4, 2018

What does this PR do?

Ensuring that when a passphrase is passed in, it is returned as a string from the passphrase callback.

What issues does this PR fix or reference?

#47236

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

garethgreenaway added some commits Jun 4, 2018

@rallytime rallytime changed the base branch from 2018.3 to 2018.3.1 Jun 5, 2018

@rallytime rallytime changed the base branch from 2018.3.1 to 2018.3 Jun 5, 2018

@rallytime rallytime merged commit 8410057 into saltstack:2018.3 Jun 5, 2018

4 of 9 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5487 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19543 — ABORTED
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17753 — FAILURE
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25695 — RUNNING
Details
WIP ready for review
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23420 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10459 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22384 — SUCCESS
Details

rallytime added a commit that referenced this pull request Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment