New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test when service doesn't exist #47959

Merged
merged 2 commits into from Jun 6, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Contributor

twangboy commented Jun 5, 2018

What does this PR do?

Fixes issue with failing test. For some reason self.assertIn wasn't working. So, I used self.assertTrue(error' in ret)`

What issues does this PR fix or reference?

Failing test

Tests written?

Yes

Commits signed with GPG?

Yes

twangboy added some commits Jun 5, 2018

@twangboy twangboy requested review from Ch3LL and saltstack/team-windows Jun 5, 2018

@dwoz

dwoz approved these changes Jun 6, 2018

@rallytime rallytime merged commit a67b21e into saltstack:2017.7 Jun 6, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10461 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19545 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25687 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17755 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5489 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23422 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22386 — SUCCESS
Details

@twangboy twangboy deleted the twangboy:fix_test_service branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment