New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tox + pytest #47968

Merged
merged 7 commits into from Jun 6, 2018

Conversation

Projects
None yet
4 participants
@gtmanfred
Contributor

gtmanfred commented Jun 5, 2018

What does this PR do?

Fixes --run-destructive and --run-expensive with pytest
Cleanup and simplify tox
Use requirements/tests.txt for installing python dependencies instead of git.salt from salt-jenkins (this will use git.minimal)

Commits signed with GPG?

Yes

@gtmanfred gtmanfred requested a review from s0undt3ch Jun 5, 2018

@s0undt3ch

The same needs to be done for expensive_test

@s0undt3ch

This comment has been minimized.

Member

s0undt3ch commented Jun 5, 2018

⭐️ ⭐️⭐️⭐️⭐️

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jun 5, 2018

Expensive Tests added

gtmanfred added some commits Jun 5, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:2017.7 branch from f801485 to 43ff9d8 Jun 6, 2018

@gtmanfred gtmanfred changed the title from set DESTRUCTIVE_TESTS environment variable for pytest to [WIP] set DESTRUCTIVE_TESTS environment variable for pytest Jun 6, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:2017.7 branch 3 times, most recently from 46104ca to 4501a46 Jun 6, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:2017.7 branch from 4501a46 to e1872e2 Jun 6, 2018

gtmanfred added some commits Jun 6, 2018

@gtmanfred gtmanfred changed the title from [WIP] set DESTRUCTIVE_TESTS environment variable for pytest to Clean up tox + pytest Jun 6, 2018

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jun 6, 2018

Ok, this is ready to go, and tests can be run using tox now.

The last thing to do is get the junits and coverage.xml dumped for Jenkins.

Daniel

@rallytime rallytime merged commit 0dcaead into saltstack:2017.7 Jun 6, 2018

6 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5550 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19605 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25748 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17815 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23482 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10522 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22446 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment