Added new state zabbix_user.admin_password_present to change zabbix pass #47970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
suggested changes
Jun 25, 2018
salt/states/zabbix_user.py
Outdated
| :param passwd: user's password | ||
| :param usrgrps: user groups to add the user to | ||
| :param medias: user's medias to create | ||
| :param medias: OPtional - user's medias to create |
salt/states/zabbix_user.py
Outdated
| .. code-block:: yaml | ||
| # password taken from pillar or _connection_password |
Contributor
There was a problem hiding this comment.
This whole block to the end of the example needs to be indented for the code-block to render correctly.
salt/states/zabbix_user.py
Outdated
| 1) Tries to log in as Admin with password found in state password parameter or _connection_password | ||
| or pillar or default zabbix password in this precise order order, if any of them is present. | ||
| 2) If one of above passwords found is successful it tries to update the most prioritized password. |
Contributor
There was a problem hiding this comment.
If one of the above passwords is found, it I think the is successful part here is redundant.
rallytime
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There was no way to change Zabbix default password statefully. This state provides it. Detailed description in docstring.
Tests written?
No
Commits signed with GPG?
Yes