Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new state zabbix_user.admin_password_present to change zabbix pass #47970

Merged
merged 4 commits into from Jul 11, 2018

Conversation

@slivik
Copy link
Contributor

@slivik slivik commented Jun 5, 2018

What does this PR do?

There was no way to change Zabbix default password statefully. This state provides it. Detailed description in docstring.

Tests written?

No

Commits signed with GPG?

Yes

Copy link
Contributor

@rallytime rallytime left a comment

Hi @slivik - I just have a couple of minor fixes. Otherwise, this looks good. Thanks for adding this.

@@ -33,7 +128,7 @@ def present(alias, passwd, usrgrps, medias, password_reset=False, **kwargs):
:param alias: user alias
:param passwd: user's password
:param usrgrps: user groups to add the user to
:param medias: user's medias to create
:param medias: OPtional - user's medias to create
Copy link
Contributor

@rallytime rallytime Jun 25, 2018

Typo: Optional

.. code-block:: yaml
# password taken from pillar or _connection_password
Copy link
Contributor

@rallytime rallytime Jun 25, 2018

This whole block to the end of the example needs to be indented for the code-block to render correctly.

1) Tries to log in as Admin with password found in state password parameter or _connection_password
or pillar or default zabbix password in this precise order order, if any of them is present.
2) If one of above passwords found is successful it tries to update the most prioritized password.
Copy link
Contributor

@rallytime rallytime Jun 25, 2018

If one of the above passwords is found, it I think the is successful part here is redundant.

@rallytime rallytime merged commit 3858e30 into saltstack:develop Jul 11, 2018
6 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants