Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new state zabbix_user.admin_password_present to change zabbix pass #47970

Merged
merged 4 commits into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@slivik
Copy link
Contributor

commented Jun 5, 2018

What does this PR do?

There was no way to change Zabbix default password statefully. This state provides it. Detailed description in docstring.

Tests written?

No

Commits signed with GPG?

Yes

@rallytime
Copy link
Contributor

left a comment

Hi @slivik - I just have a couple of minor fixes. Otherwise, this looks good. Thanks for adding this.

@@ -33,7 +128,7 @@ def present(alias, passwd, usrgrps, medias, password_reset=False, **kwargs):
:param alias: user alias
:param passwd: user's password
:param usrgrps: user groups to add the user to
:param medias: user's medias to create
:param medias: OPtional - user's medias to create

This comment has been minimized.

Copy link
@rallytime

rallytime Jun 25, 2018

Contributor

Typo: Optional

.. code-block:: yaml
# password taken from pillar or _connection_password

This comment has been minimized.

Copy link
@rallytime

rallytime Jun 25, 2018

Contributor

This whole block to the end of the example needs to be indented for the code-block to render correctly.

1) Tries to log in as Admin with password found in state password parameter or _connection_password
or pillar or default zabbix password in this precise order order, if any of them is present.
2) If one of above passwords found is successful it tries to update the most prioritized password.

This comment has been minimized.

Copy link
@rallytime

rallytime Jun 25, 2018

Contributor

If one of the above passwords is found, it I think the is successful part here is redundant.

slivik added some commits Jul 10, 2018

@rallytime rallytime merged commit 3858e30 into saltstack:develop Jul 11, 2018

6 of 17 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
codeclimate 4 issues to fix
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24272 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11314 — FAILURE
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6344 — RUNNING
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20397 — RUNNING
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26556 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18589 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23225 — SUCCESS
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.