New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try/finally, fix typo in 7zip def file #47978

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
4 participants
@twangboy
Contributor

twangboy commented Jun 5, 2018

What does this PR do?

Two tests were failing on Windows:

  • integration.states.test_pkg.PkgTest.test_pkg_003_installed_multipkg
  • integration.states.test_pkg.PkgTest.test_pkg_004_installed_multipkg_with_version

What issues does this PR fix or reference?

Failing tests in jenkins

Tests written?

Yes

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Jun 5, 2018

@twangboy twangboy requested review from Ch3LL and saltstack/team-windows and removed request for saltstack/team-windows Jun 5, 2018

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented Jun 6, 2018

Assume these test install 7zip, can the test confirm the 7Zip binary is on the C Drive.

@dwoz

dwoz approved these changes Jun 6, 2018

@rallytime rallytime merged commit 42dd6b8 into saltstack:2017.7 Jun 6, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19568 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5513 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25711 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17778 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23445 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10485 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22409 — SUCCESS
Details

@twangboy twangboy deleted the twangboy:fix_test_pkg branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment