Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd salt-api on Windows platform #48001
Conversation
salt-jenkins
requested review from
saltstack/team-core
Jun 6, 2018
gtmanfred
approved these changes
Jun 6, 2018
isbm
approved these changes
Jun 7, 2018
rallytime
requested a review
from saltstack/team-windows
Jun 7, 2018
dwoz
approved these changes
Jun 8, 2018
This comment has been minimized.
This comment has been minimized.
|
@rares-pop Can you add this to the Fluorine release notes? |
rares-pop
force-pushed the
rares-pop:dev/iepopr/add_salt-api_windows
branch
from
174dc2e
to
c640b5c
Jun 11, 2018
This comment has been minimized.
This comment has been minimized.
|
I did add a release note, but please review it and tell me if it looks right. |
rallytime
suggested changes
Jun 11, 2018
|
Thanks @rares-pop! I have a couple of very small requests. Once those are fixed up, we can get this in. :) |
doc/topics/releases/fluorine.rst
Outdated
| @@ -624,3 +624,14 @@ New style for including from a parent directory: | |||
| .. code-block:: jinja | |||
|
|
|||
| {% from '../foo' import bar %} | |||
|
|
|||
| salt-api | |||
| ============================ | |||
This comment has been minimized.
This comment has been minimized.
rallytime
Jun 11, 2018
Contributor
This is picky, but can you make this line the same length as the text?
salt-api
========
We just spent a bunch of time fixing up RST syntax errors, so we want to keep these clean :D
doc/topics/releases/fluorine.rst
Outdated
| ============================ | ||
|
|
||
| salt-api Windows support | ||
| -------------------------------- |
This comment has been minimized.
This comment has been minimized.
doc/topics/releases/fluorine.rst
Outdated
| -------------------------------- | ||
|
|
||
| Previously, salt-api was was not supported on the Microsoft Windows platforms. Now it is! | ||
| salt-api is providing a RESTful interface to a running Salt system. It allows |
This comment has been minimized.
This comment has been minimized.
doc/topics/releases/fluorine.rst
Outdated
| Previously, salt-api was was not supported on the Microsoft Windows platforms. Now it is! | ||
| salt-api is providing a RESTful interface to a running Salt system. It allows | ||
| for viewing minions, runners, and jobs as well as running execution modules | ||
| and runners of a running Salt system through a REST API that returns JSON. |
This comment has been minimized.
This comment has been minimized.
rallytime
Jun 11, 2018
Contributor
Adding a link to the Salt-API documentation might be a good idea here. :)
This comment has been minimized.
This comment has been minimized.
rares-pop
Jun 11, 2018
Author
Contributor
Regarding Salt-API documentation, do you mean:
https://salt.readthedocs.io/projects/salt-api
or
https://docs.saltstack.com/topics/netapi/index.html
or something else?
This comment has been minimized.
This comment has been minimized.
rallytime
Jun 11, 2018
Contributor
Ah, sorry I was unclear. The second one: https://docs.saltstack.com/en/latest/topics/netapi/index.html
rallytime
approved these changes
Jun 11, 2018
rallytime
merged commit 037d198
into
saltstack:develop
Jun 11, 2018
4 of 10 checks passed
jenkins/PR/salt-pr-linode-ubuntu16-py3
Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10606 — ABORTED
Details
codeclimate
3 issues to fix
Details
default
Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3
Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5635 — FAILURE
Details
jenkins/PR/salt-pr-lint-n
Pull Requests » Salt PR - Code Lint #22529 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n
Pull Requests » Salt PR - RS CentOS 7 #19689 — FAILURE
Details
WIP
ready for review
Details
jenkins/PR/salt-pr-clone
Pull Requests » Salt PR - Clone #25833 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n
Pull Requests » Salt PR - Docs #17898 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n
Pull Requests » Salt PR - Linode Ubuntu14.04 #23565 — SUCCESS
Details
rares-pop
deleted the
rares-pop:dev/iepopr/add_salt-api_windows
branch
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rares-pop commentedJun 6, 2018
•
edited
salt-api is broken on Windows platform
due to pickling issues on the salt.loader.netapi
Workaround that by creating a runner class
that can be pickled.
Signed-off-by: Rares POP rares.pop@ni.com
What does this PR do?
It adds/fixes salt-api on the Windows platform, using rest_cherrypy module
Previous Behavior
salt-api wasn't available on Windows
New Behavior
The user is able to run the salt-api daemon on windows, using rest_cherrypy module
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.