Add salt-api on Windows platform #48001
Conversation
ghost
requested review from
|
@rares-pop Can you add this to the Fluorine release notes? |
salt-api is broken on Windows platform due to pickling issues on the salt.loader.netapi Workaround that by creating a runner class that can be pickled. Signed-off-by: Rares POP <rares.pop@ni.com>
Signed-off-by: Rares POP <rares.pop@ni.com>
|
I did add a release note, but please review it and tell me if it looks right. |
There was a problem hiding this comment.
Thanks @rares-pop!
I have a couple of very small requests. Once those are fixed up, we can get this in. :)
doc/topics/releases/fluorine.rst
Outdated
| @@ -624,3 +624,14 @@ New style for including from a parent directory: | |||
| .. code-block:: jinja | |||
|
|
|||
| {% from '../foo' import bar %} | |||
|
|
|||
| salt-api | |||
| ============================ | |||
There was a problem hiding this comment.
This is picky, but can you make this line the same length as the text?
salt-api
========
We just spent a bunch of time fixing up RST syntax errors, so we want to keep these clean :D
doc/topics/releases/fluorine.rst
Outdated
| ============================ | ||
|
|
||
| salt-api Windows support | ||
| -------------------------------- |
doc/topics/releases/fluorine.rst
Outdated
| -------------------------------- | ||
|
|
||
| Previously, salt-api was was not supported on the Microsoft Windows platforms. Now it is! | ||
| salt-api is providing a RESTful interface to a running Salt system. It allows |
There was a problem hiding this comment.
salt-api is providing should be salt-api provides
doc/topics/releases/fluorine.rst
Outdated
| Previously, salt-api was was not supported on the Microsoft Windows platforms. Now it is! | ||
| salt-api is providing a RESTful interface to a running Salt system. It allows | ||
| for viewing minions, runners, and jobs as well as running execution modules | ||
| and runners of a running Salt system through a REST API that returns JSON. |
There was a problem hiding this comment.
Adding a link to the Salt-API documentation might be a good idea here. :)
There was a problem hiding this comment.
Regarding Salt-API documentation, do you mean:
https://salt.readthedocs.io/projects/salt-api
or
https://docs.saltstack.com/topics/netapi/index.html
or something else?
There was a problem hiding this comment.
Ah, sorry I was unclear. The second one: https://docs.saltstack.com/en/latest/topics/netapi/index.html
Signed-off-by: Rares POP <rares.pop@ni.com>
salt-api is broken on Windows platform
due to pickling issues on the salt.loader.netapi
Workaround that by creating a runner class
that can be pickled.
Signed-off-by: Rares POP rares.pop@ni.com
What does this PR do?
It adds/fixes salt-api on the Windows platform, using rest_cherrypy module
Previous Behavior
salt-api wasn't available on Windows
New Behavior
The user is able to run the salt-api daemon on windows, using rest_cherrypy module
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.