New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find job pause #48014

Merged
merged 3 commits into from Jun 8, 2018

Conversation

Projects
None yet
3 participants
@cro
Member

cro commented Jun 7, 2018

What does this PR do?

Fixes a few cases where the jobs runner would stacktrace if it could not communicate with a returner or external job cache.

Previous Behavior

If a returner could not be contacted, functions in the jobs runner (like jobs.active) would stacktrace.

New Behavior

Stacktraces are avoided, and in some cases a more helpful error message is presented.

Tests written?

No

Commits signed with GPG?

Yes

cro added some commits Jun 7, 2018

@rallytime rallytime requested a review from garethgreenaway Jun 7, 2018

@rallytime rallytime merged commit dcae209 into saltstack:2018.3 Jun 8, 2018

9 checks passed

WIP ready for review
Details
default Build finished.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25765 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17831 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5567 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23498 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10538 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22462 — SUCCESS
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19622 — SUCCESS
Details

rallytime added a commit that referenced this pull request Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment