New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

states/github.py fix for incorrect positional argument #48040

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
2 participants
@twellspring
Contributor

twellspring commented Jun 8, 2018

What does this PR do?

Updated add_team_repo to not put the permission positional argument into the profile variable. Syntax used is the same as the 2 other uses of add_team_repo in this same file.

What issues does this PR fix or reference?

#48039

Previous Behavior

Stack trace and state failure

New Behavior

works

Tests written?

No

Commits signed with GPG?

no

@rallytime rallytime merged commit a10fbf9 into saltstack:develop Jun 11, 2018

3 of 10 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10570 — ABORTED
Details
codeclimate 1 issue to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5599 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23529 — FAILURE
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22493 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19653 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25797 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17862 — SUCCESS
Details

rallytime added a commit that referenced this pull request Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment