SmartOS imgadm module and state did not like docker images #48046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorge
changed the title
Contributor
Author
|
I will be super busy the coming week/weekend, but smartos_vmadm should also be updated to not error on docker images. Fixing this is a requirement for smartos_vmadm, I will deal with smartos_vmadm once this is merged and I am less busy. |
Contributor
Author
|
Lint and test failures seem to be unrelated. |
rallytime
suggested changes
Jun 11, 2018
Contributor
rallytime
left a comment
rallytime
left a comment
There was a problem hiding this comment.
Some minor documentation requests from me. :)
salt/modules/smartos_imgadm.py
Outdated
Contributor
There was a problem hiding this comment.
This should be Fluorine, yes?
salt/modules/smartos_imgadm.py
Outdated
Contributor
There was a problem hiding this comment.
This should be Fluorine.
salt/modules/smartos_imgadm.py
Outdated
Contributor
There was a problem hiding this comment.
This new function, as well as all of the the other new functions below, should have a versionadded tag for Fluorine. :)
For a while now SmartOS has support for docker images, importing one would make smartos_imgadm error. Listing images with docker images installed has the same result.
Like the imgadm module the imgadm states for SmartOS did not handle docker images. With this commit those now work as expected.
Contributor
Author
|
Done and rebased on develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the importing and managing of docker images on SmartOS.
What issues does this PR fix or reference?
N/a
Previous Behavior
Exceptions were encountered when trying to import docker images.
New Behavior
Docker images can now be imported and managed properly.
Tests written?
No
Commits signed with GPG?
No
Backporting
It's a rather large fix so I would prefer to keep it in develop only, although there is no functional change compared to 2018.3.x so it may be worth while pulling this in.