New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark test as expensive #48060

Merged
merged 2 commits into from Jun 13, 2018

Conversation

Projects
None yet
4 participants
@gtmanfred
Contributor

gtmanfred commented Jun 11, 2018

What does this PR do?

This tests takes a large amount of cpu to run, and is causing tests to
hang.

Mark it as an expensive test so it only runs with the cloud tests.

What issues does this PR fix or reference?

Trying to clean up some tests that might be causing 2018.3 to take a long time to run.

Commits signed with GPG?

Yes

mark test as expensive
This tests takes a large amount of cpu to run, and is causing tests to
hang.

Mark it as an expensive test so it only runs with the cloud tests.

@gtmanfred gtmanfred requested a review from garethgreenaway Jun 11, 2018

@cachedout

This comment has been minimized.

Contributor

cachedout commented Jun 12, 2018

Is this just looping through the while True: loop without sleeping? It probably just needs a 50ms sleep or something in there and it should be fine.

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jun 12, 2018

I tried that, and it did not reduce the cpu/memory consumption.

It is actually the same way that the rest of the event listening stuff is running.

https://github.com/saltstack/salt/blob/2017.7/salt/modules/state.py#L2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented Jun 12, 2018

I will say too that this is the best test result we've seen on this branch for a while, FWIW.

@rallytime rallytime merged commit c83818e into saltstack:2018.3 Jun 13, 2018

9 checks passed

WIP ready for review
Details
default Build finished.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25883 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17945 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5684 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23614 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10655 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22576 — SUCCESS
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19738 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment