Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[2017.7] Ensure that the shared list of jids is passed #48075
What does this PR do?
Ensure that the shared list of jids is passed when creating the Minion. Fixes an issue when minions are pointed at multiple syndics.
What issues does this PR fix or reference?
When using multiple syndic servers commands would result in multiple returns as the de-duplication function was not functioning correctly.
When the minion is created set the jid_queue to an empty list only if the value passed in is actually None, otherwise set it to the value that is passed in.
No. Unfortunately this issue only occurs when a minion is pointed at multiple syndic servers and the command is issued from the master of masters. Current testing setup doesn't support multiple syndics.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.