New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] Ensure that the shared list of jids is passed #48075

Merged
merged 1 commit into from Jun 13, 2018

Conversation

Projects
None yet
4 participants
@garethgreenaway
Member

garethgreenaway commented Jun 12, 2018

What does this PR do?

Ensure that the shared list of jids is passed when creating the Minion. Fixes an issue when minions are pointed at multiple syndics.

What issues does this PR fix or reference?

#48038

Previous Behavior

When using multiple syndic servers commands would result in multiple returns as the de-duplication function was not functioning correctly.

New Behavior

When the minion is created set the jid_queue to an empty list only if the value passed in is actually None, otherwise set it to the value that is passed in.

Tests written?

No. Unfortunately this issue only occurs when a minion is pointed at multiple syndic servers and the command is issued from the master of masters. Current testing setup doesn't support multiple syndics.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Ensure that the shared list of jids is passed when creating the Minio…
…n. Fixes an issue when minions are pointed at multiple syndics.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core as a code owner Jun 12, 2018

@rallytime rallytime merged commit d6d2c5e into saltstack:2017.7 Jun 13, 2018

7 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19735 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25879 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17943 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5680 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23611 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10651 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22574 — SUCCESS
Details

rallytime added a commit that referenced this pull request Jun 14, 2018

rallytime added a commit that referenced this pull request Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment