Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix UnicodeDecodeError when parsing hosts file with non-ascii #48081
This also adds a regression test, and I also added the following goodies to mock_open while I was writing the test:
referenced this pull request
Jun 13, 2018
@twangboy can you have a look at the mac_sysctl changes? I have the tests passing now but I think that
@terminalmage The tests on the Ubuntu 16 Py3 build are not failing on the branch, so I think they're related to this. Can you take another look?