New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkinsfiles to define tests in 2018 #48116

merged 4 commits into from Jun 18, 2018


None yet
3 participants

KaiSforza commented Jun 13, 2018

What does this PR do?

Adds jenkinsfiles to the .ci/ directory, allowing us to use Jenkins Pipelines.

Previous Behavior

Manually specified jobs on our Jenkins node

New Behavior

Automatically scans for branches with these files and runs a job defined in them (what file to look for still has to be defined on the jenkins master, though).

Tests written?

Look at me. I am the tests now.

Commits signed with GPG?


@gtmanfred @dubb-b


This comment has been minimized.


cachedout commented Jun 14, 2018

Hmm. I guess my first question is whether the salt repo is the right place for this. I know very little about Jenkins pipelines but one thought is whether it might make sense to break this into a separate repo and then clone from it before cloning from Salt. Is something like that possible?


This comment has been minimized.


KaiSforza commented Jun 14, 2018

Currently this is the implementation that we've tested. I haven't tried splitting these out into another repo, but we would lose a lot of the automation that having them in this repo gives us (easy clones, easy github pr updates, easily knows about changes to the repo, etc.).


This comment has been minimized.


gtmanfred commented Jun 14, 2018

The ci files are supposed to be in the github repository that they are testing.

This is how Jenkins adapted to the paradigm created by drone/travisci/circleci, etc.

@cachedout cachedout merged commit 0f95238 into saltstack:2018.3 Jun 18, 2018

6 of 9 checks passed

default Build finished.
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5726 — FAILURE
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19780 — FAILURE
WIP ready for review
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25929 — SUCCESS
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #17987 — SUCCESS
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23656 — SUCCESS
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10697 — SUCCESS
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22622 — SUCCESS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment