Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
service.disabled on Windows #48117
What does this PR do?
Disable services that are set to manual on Windows using
What issues does this PR fix or reference?
Now manual start types are properly disabled.
Commits signed with GPG?
Please add functions to the execution module instead.
I think it comes down to definitions:
I am not convinced of this change
I think the real need is to rewrite service in more open terms and not "specific platform terms" e.g. "service.dead" is bad name.
I think service state should be changed to the following i.e. create the following, and place warning on the old methods. (or have both)
automatic* and enable can mean the same thing.
My thoughts are leave it like it is, close this PR and open one to introduce new state called service.status
PS Second thought.
The something like the above. Where the platform implementation can decide what to use e.g. systemd platform would use the systemd settings above using init.d settings. If systemd is replaced, then it will also handle the next bright idea which comes along.
This PR addresses an open issue #48026 and fixes some broken integration tests.
Lets merge it and discuss changes to the service semantics in a separate issue (not a PR).