New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix py3-incompatible dict.keys()[x] call in apk.py #48131

Merged
merged 2 commits into from Jun 19, 2018

Conversation

Projects
None yet
2 participants
@bowmanjd-lms
Contributor

bowmanjd-lms commented Jun 14, 2018

What does this PR do?

Fixes Python3-incompatible dict.keys()[x] call in apk.py

What issues does this PR fix or reference?

#48128

Previous Behavior

TypeError: 'dict_keys' object does not support indexing

New Behavior

Works

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Fix py3-incompatible dict.keys()[x] call in apk.py
Fixes #48128

Previous line worked fine on Python 2.7, but on 3, emits:

`TypeError: 'dict_keys' object does not support indexing`
@rallytime

This comment has been minimized.

Contributor

rallytime commented Jun 19, 2018

Thank you for fixing this @bowmanjd-lms! And congrats on your first Salt PR! :)

@rallytime rallytime merged commit 6929423 into saltstack:2017.7 Jun 19, 2018

5 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
default Build finished.
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18059 — FAILURE
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5801 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19855 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26004 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23731 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10772 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22694 — SUCCESS
Details

@bowmanjd-lms bowmanjd-lms deleted the bowmanjd-lms:fix-apk-python3 branch Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment