New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sorting of multi-version packages #48147

Merged
merged 2 commits into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@brejoc
Member

brejoc commented Jun 15, 2018

What does this PR do?

This commit introduced a regression for the multi version support. Since version numbers are not correctly sorted, older packages might be reported as the most recent version.

Since we can only use key as a parameter to sorted (because of Python3), we can't use version_cmp as is. Instead we would have to introduce a wrapper to do so. Or, like suggested in this PR, use LooseVersion from distutils.version.

What issues does this PR fix or reference?

None

Previous Behavior

Old version of multi version packages might be reported as the most recent ones.

New Behavior

Only the most recent versions for multi version packages are reported as installed.

Tests written?

No

Commits signed with GPG?

Yes

brejoc added some commits Jun 13, 2018

@rallytime rallytime requested review from terminalmage and isbm Jun 15, 2018

@isbm

isbm approved these changes Jun 15, 2018

@rallytime rallytime merged commit 8cf0311 into saltstack:2018.3 Jun 15, 2018

6 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23690 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19814 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #25963 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18018 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5760 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10731 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22653 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment