PR 44366 #48182
PR 44366 #48182
Conversation
ghost
self-requested a review
| # prepend root_dir | ||
| prepend_root_dirs = ['cachedir'] | ||
| prepend_root_dirs = ['cachedir','log_file'] | ||
| prepend_root_dir(opts, prepend_root_dirs) |
There was a problem hiding this comment.
@samilaine but can we maybe not to call this list "prepend_root_dirs", since it is path options? I understand that the variable was already there, but let's agree it is greatly misleading name. Maybe I would just do it so:
prepend_root_dir(opts, ['cachedir','log_file'])So whoever wants to know how this is working, can lookup the function and see that this is just a path_options.
There was a problem hiding this comment.
However, it turns out that there might be a reasonable explanation for that funny variable prepend_root_dirs (see line 2358 in salt/config/__init__.py) .
So, instead of getting rid of the funny variable, I opted for abusing it even more.
There was a problem hiding this comment.
for the record, i am for leaving the variable, as it is how all the other config functions work, master_config, minion_config, etc.
There was a problem hiding this comment.
@samilaine 😉 Well, OK. I approved this anyway, and that one was up to you. Thanks!
4 participants
What does this PR do?
Allows Salt Cloud to operate within a separate directory tree without having to define the configuration directive
log_fileseparately (on the command line or in the main cloud configuration file).What issues does this PR fix or reference?
#44366
Previous Behavior
A user has to specify
--log-fileseparately, even ifroot_diris specified in the main cloud configuration file and-cis being used on the command line.New Behavior
Running SaltCloud with non-default configuration file locations works as expected ie. the log file ends up under the directory hierarchy specified in 'root_dir' directive in the main salt cloud configuration file.
Tests written?
No
Commits signed with GPG?
No