New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call .exception() on future unless it's done. #48185

Merged
merged 2 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@DmitryKuzmenko
Contributor

DmitryKuzmenko commented Jun 18, 2018

What does this PR do?

Avoid calling future.exception() unless the future is done. This prevents an exception to be raised from tornado code that checks is the future done before retrieving the exception.

What issues does this PR fix or reference?

Fix #47901

Tests written?

No

Commits signed with GPG?

Yes

@DmitryKuzmenko DmitryKuzmenko requested a review from saltstack/team-core as a code owner Jun 18, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-transport Jun 18, 2018

@DmitryKuzmenko DmitryKuzmenko force-pushed the DSRCorporation:bugs/47901_future_done_exception branch from c8f026a to 9f2dbf9 Jun 18, 2018

@DmitryKuzmenko DmitryKuzmenko changed the base branch from 2017.7.7 to 2017.7 Jun 18, 2018

@rallytime rallytime merged commit 868c173 into saltstack:2017.7 Jun 19, 2018

5 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18106 — FAILURE
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5848 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19902 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26051 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23778 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10819 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22741 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment