New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If pip binary is passed to bin_env, use that pip binary #48189

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
4 participants
@gtmanfred
Contributor

gtmanfred commented Jun 18, 2018

What does this PR do?

We don't need to do a lookup for python to then run python -m pip
because we already know where pip is.

Fixes using /bin/pip3

What issues does this PR fix or reference?

Fixes #48122

Tests written?

Yes

Commits signed with GPG?

Yes

If pip binary is passed to bin_env, use that pip binary
We don't need to do a lookup for python to then run `python -m pip`
because we already know where pip is.

Fixes using /bin/pip3

Fixes #48122

@gtmanfred gtmanfred force-pushed the gtmanfred:pip branch from c218cd9 to 96c59f3 Jun 18, 2018

@rallytime rallytime merged commit 96f79b0 into saltstack:2018.3 Jun 19, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10805 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26037 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18092 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5834 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23764 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22727 — SUCCESS
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19888 — SUCCESS
Details

rallytime added a commit that referenced this pull request Jun 25, 2018

@gtmanfred gtmanfred deleted the gtmanfred:pip branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment