Minor improvements and fixes for related PR: #48062 #48199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh_gateway_command needs to be duplicated first, otherwise kwargs will not contain user setting for them at the time __ssh_gateway_arguments is called.
ghost
self-requested a review
|
Transcript of manual test : https://gist.github.com/icy/79de9efdbd35313640e5ce321a95db4b |
gtmanfred
approved these changes
Jun 19, 2018
rallytime
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Minor improvements and fixes for related PR: #48062.
The dictionary item
ssh_gateway_commandneeds to be duplicated before being used in__ssh_gateway_arguments.What issues does this PR fix or reference?
Minor improvements and fixes for related PR: #48062.
Previous Behavior
ssh_gateway_commandsetting is not known when runningsalt-cloudNew Behavior
ssh_gateway_commandsetting is known correctly when runningsalt-cloudTests written?
NO
Manual tests at developer's side: yes (by running
salt-cloudwith different configuration). See the transcript log in the first command on this thread.Commits signed with GPG?
Yes