Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements and fixes for related PR: #48062 #48199

Merged
merged 4 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@icy
Copy link
Contributor

commented Jun 19, 2018

What does this PR do?

Minor improvements and fixes for related PR: #48062.

The dictionary item ssh_gateway_command needs to be duplicated before being used in __ssh_gateway_arguments.

What issues does this PR fix or reference?

Minor improvements and fixes for related PR: #48062.

Previous Behavior

ssh_gateway_command setting is not known when running salt-cloud

New Behavior

ssh_gateway_command setting is known correctly when running salt-cloud

Tests written?

NO

Manual tests at developer's side: yes (by running salt-cloud with different configuration). See the transcript log in the first command on this thread.

Commits signed with GPG?

Yes

icy added some commits Jun 19, 2018

salt/utils/cloud: duplicate ssh_gateway_command before using
ssh_gateway_command needs to be duplicated first, otherwise kwargs will not
contain user setting for them at the time __ssh_gateway_arguments is called.

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Jun 19, 2018

@icy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2018

icy added some commits Jun 19, 2018

@rallytime rallytime merged commit ee11ae5 into saltstack:develop Jun 19, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10817 — ABORTED
Details
codeclimate 1 issue to fix
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5846 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19900 — FAILURE
Details
default Build started sha1 is merged.
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26049 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18104 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23776 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22739 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.