New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python3 ec2 salt-cloud TypeError when installing salt #48212

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
3 participants
@Ch3LL
Contributor

Ch3LL commented Jun 19, 2018

What does this PR do?

Fixes TypeError when trying to install salt on VM during creation.

What issues does this PR fix or reference?

Fixes: #48206

Tests written?

Yes - This was found due to tests that were failing

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Jun 19, 2018

@rallytime rallytime merged commit 77a75eb into saltstack:2018.3 Jun 20, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5868 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19922 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26071 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18125 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23798 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10839 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22760 — SUCCESS
Details

@Ch3LL Ch3LL referenced this pull request Aug 9, 2018

Closed

[2017.7.8] test_ec2 failing #1051

Ch3LL added a commit to Ch3LL/salt that referenced this pull request Aug 9, 2018

rallytime added a commit that referenced this pull request Aug 9, 2018

Merge pull request #49041 from Ch3LL/ec2_fix
[2017.7.8] backport PR #48212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment