New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnicodeDecodeError when reading file to determine virtual grain #48216

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
2 participants
@Ch3LL
Contributor

Ch3LL commented Jun 19, 2018

What does this PR do?

Fixes the UnicodeDecodeError when trying to read /sys/devices/virtual/dmi/id/product_name file when it contains non ascii characters.

What issues does this PR fix or reference?

#48184

@rallytime

This comment has been minimized.

Contributor

rallytime commented Jun 20, 2018

re-run py3

@rallytime rallytime merged commit 6072d1e into saltstack:2018.3 Jun 20, 2018

6 of 9 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10859 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #19928 — FAILURE
Details
default Build started sha1 is merged.
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26091 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18131 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5888 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23804 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22766 — SUCCESS
Details

mmulqueen added a commit to mmulqueen/salt that referenced this pull request Jul 4, 2018

mmulqueen added a commit to mmulqueen/salt that referenced this pull request Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment