Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix GlusterFS module for version 4.0 and above #48222
What does this PR do?
Fix for versions of GlusterFS 4.0 and above. In the GlusterFS module, there are conditions checking the version of GFS lower than 3.6, because it uses different syntax to parse the response. Unfortunately, the condition on checks minor version, so when running a version 4.0, it fails, because 0 < 6 = true.
What issues does this PR fix or reference?
Fixed by changing the condition to compare both minor and major versions.
Failed to parse the response causing the state to fail.
State successfully finished.
Hi @Martin819 - This is failing some tests. Can you take a look?
Hi @Martin819 - There's just one more glusterfs test failure that needs to be fixed.
Jun 28, 2018
10 of 17 checks passed
Hi @Martin819 - It looks like this module has diverged in develop from the earlier branches and this won't back-port cleanly. If you'd like this fix to be in 2017.7, then you'll need to make a separate fix against that branch. Would you mind submitting that?