Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a few helpers to gate functionality from netmiko into the NAPALM proxy minions #48264

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
2 participants
@mirceaulinic
Copy link
Member

commented Jun 22, 2018

netmiko is already a dependency of napalm, therefore we are able to
expose all the netmiko functionalities from the netmiko execution
module without having to run under a netmiko Proxy Minion: see
#48260, which is the PR adding the netmiko
execution module.

These new functions added to the existing napalm module gate netmiko's features
to be reused into the napalm Proxy Minions, by forwarding the authentication
details and options which are already there.

For example, the following function goes through the netmiko Execution
Module, and napalm users can invoke it straight away to get direct access to
basic SSH primitives: salt '*' napalm.netmiko_call send_command 'show version'.
(without any further configuration needed).

Adding a few helpers to gate functionality from netmiko into the napa…
…lm proxy minions

``netmiko`` is already a dependency of ``napalm``, therefore we are able to
expose all the ``netmiko`` functionalities from the ``netmiko`` execution
module without having to run under a netmiko Proxy Minion: see
#48260, which is the PR adding the netmiko
execution module.

These new functions added to the existing napalm module gate netmiko's features
to be reused into the napalm Proxy Minions, by forwarding the authentication
details and options which are already there.

For example, the following function goes through the ``netmiko`` Execution
Module, and napalm users can invoke it straight away to get direct access to
basic SSH primitives: ``salt '*' napalm.netmiko_call send_command 'show version'``.
(without any further configuration needed).

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:napalm-netmiko-gate branch from 6f9c270 to 243ba9c Jun 25, 2018

@rallytime rallytime merged commit e0d76b0 into saltstack:develop Jun 25, 2018

7 of 12 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #10961 — ABORTED
Details
codeclimate 3 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #5991 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20044 — FAILURE
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26195 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18245 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23919 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22880 — SUCCESS
Details
jenkins/pr/lint The lint job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.