Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for tagging ec2 instance spot requests #48305

Merged

Conversation

thetoolsmith
Copy link
Contributor

This change enabled support for creating tags for aws ec2 spot instance requests using salt-cloud configuration file.

Salt-cloud does not currently support this.

Tags can be set on AWS ec2 spot instance with the following salt-cloud configuration.
my-ec2-config:
spot_config:
spot_price: 0.10
tag:
first_tag: first tag value
second_tag: second tag value
...
...

Tests have not been written

Commits signed with GPG?

No

@ghost ghost self-requested a review June 25, 2018 22:46
Copy link
Contributor

@gtmanfred gtmanfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the ec2 getting started documentation?

https://docs.saltstack.com/en/latest/topics/cloud/aws.html

Thanks,
Daniel

@thetoolsmith
Copy link
Contributor Author

Documentation update has been committed.

@gtmanfred
Copy link
Contributor

Thanks!

@rallytime rallytime merged commit b4f81b8 into saltstack:develop Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants