Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for tagging ec2 instance spot requests #48305

Merged

Conversation

Projects
None yet
3 participants
@thetoolsmith
Copy link
Contributor

commented Jun 25, 2018

This change enabled support for creating tags for aws ec2 spot instance requests using salt-cloud configuration file.

Salt-cloud does not currently support this.

Tags can be set on AWS ec2 spot instance with the following salt-cloud configuration.
my-ec2-config:
spot_config:
spot_price: 0.10
tag:
first_tag: first tag value
second_tag: second tag value
...
...

Tests have not been written

Commits signed with GPG?

No

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Jun 25, 2018

Paul Bruno added some commits Jun 26, 2018

Paul Bruno
Paul Bruno
@gtmanfred
Copy link
Contributor

left a comment

Can you add this to the ec2 getting started documentation?

https://docs.saltstack.com/en/latest/topics/cloud/aws.html

Thanks,
Daniel

Paul Bruno and others added some commits Jun 26, 2018

Paul Bruno
Paul Bruno
@thetoolsmith

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2018

Documentation update has been committed.

Paul Bruno
@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

Thanks!

@rallytime rallytime merged commit b4f81b8 into saltstack:develop Jun 26, 2018

6 of 10 checks passed

default Pull Requests » Salt PR - Main Build - PY2/PY3 #9770
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11013 — ABORTED
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6043 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20096 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26247 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18294 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #23971 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22929 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.