Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new netmiko and junos functions to the napalm module #48313

Merged
merged 3 commits into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@mirceaulinic
Copy link
Member

commented Jun 26, 2018

To gate functionality from the junos Execution Module, by reusing the
existing connection from NAPALM.
At the same time, add two more handy functions that leverage the connection via the Netmiko module by reusing the connection arguments: send_commands and send_config.

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:napalm-junos-gate branch from 3e2e436 to fb06412 Jun 26, 2018

Add new netmiko and junos functions to the napalm module
To gate functionality from the ``junos`` Execution Module, by reusing the
existing connection.

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:napalm-junos-gate branch from fb06412 to 37ac99a Jun 26, 2018

@rallytime
Copy link
Contributor

left a comment

A couple of comments/questions from me. :)

@@ -493,6 +493,7 @@ def exit_config_mode(**kwargs):
def send_config(config_file=None,
config_commands=None,
template_engine='jinja',
commit=False,

This comment has been minimized.

Copy link
@rallytime

rallytime Jun 27, 2018

Contributor

This looks like an API change - can you add this to tend of the list, just in case?

This comment has been minimized.

Copy link
@mirceaulinic

mirceaulinic Jun 28, 2018

Author Member

The netmiko module has been just added #48260 - there might be other upcoming changes if I notice anything misbehaving, sorry.

This comment has been minimized.

Copy link
@rallytime

rallytime Jun 28, 2018

Contributor

Oh! I should have checked. Thanks! :)

@@ -501,7 +502,7 @@ def send_config(config_file=None,
attrs=None,
context=None,
defaults=None,
skip_verify=False,
skip_verify=True,

This comment has been minimized.

Copy link
@rallytime

rallytime Jun 27, 2018

Contributor

Why is this default changing? That at least needs to be documented.

This comment has been minimized.

Copy link
@mirceaulinic

mirceaulinic Jun 28, 2018

Author Member

Indeed, it shouldn't. Reverted.

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:napalm-junos-gate branch from 5a5dec1 to f636dc7 Jun 28, 2018

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:napalm-junos-gate branch from f636dc7 to 634f11e Jun 28, 2018

@rallytime rallytime merged commit 98d0a15 into saltstack:develop Jun 28, 2018

9 of 17 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11063 — ABORTED
Details
codeclimate 4 issues to fix
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6093 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20146 — FAILURE
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
default Build started sha1 is merged.
Details
WIP (beta) ready
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26297 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18343 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24021 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22978 — SUCCESS
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.