Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new netmiko and junos functions to the napalm module #48313

Merged
merged 3 commits into from Jun 28, 2018

Conversation

mirceaulinic
Copy link
Contributor

To gate functionality from the junos Execution Module, by reusing the
existing connection from NAPALM.
At the same time, add two more handy functions that leverage the connection via the Netmiko module by reusing the connection arguments: send_commands and send_config.

To gate functionality from the ``junos`` Execution Module, by reusing the
existing connection.
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments/questions from me. :)

@@ -493,6 +493,7 @@ def exit_config_mode(**kwargs):
def send_config(config_file=None,
config_commands=None,
template_engine='jinja',
commit=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an API change - can you add this to tend of the list, just in case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The netmiko module has been just added #48260 - there might be other upcoming changes if I notice anything misbehaving, sorry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I should have checked. Thanks! :)

@@ -501,7 +502,7 @@ def send_config(config_file=None,
attrs=None,
context=None,
defaults=None,
skip_verify=False,
skip_verify=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this default changing? That at least needs to be documented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it shouldn't. Reverted.

@rallytime rallytime merged commit 98d0a15 into saltstack:develop Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants