Add new netmiko and junos functions to the napalm module - #48313
Merged
Conversation
mirceaulinic
force-pushed
the
napalm-junos-gate
branch
from
June 26, 2018 12:38
3e2e436 to
fb06412
Compare
To gate functionality from the ``junos`` Execution Module, by reusing the existing connection.
mirceaulinic
force-pushed
the
napalm-junos-gate
branch
from
June 26, 2018 12:44
fb06412 to
37ac99a
Compare
rallytime
suggested changes
Jun 27, 2018
rallytime
left a comment
rallytime
left a comment
Contributor
There was a problem hiding this comment.
A couple of comments/questions from me. :)
Contributor
There was a problem hiding this comment.
This looks like an API change - can you add this to tend of the list, just in case?
Contributor
Author
There was a problem hiding this comment.
The netmiko module has been just added #48260 - there might be other upcoming changes if I notice anything misbehaving, sorry.
Contributor
There was a problem hiding this comment.
Oh! I should have checked. Thanks! :)
Contributor
There was a problem hiding this comment.
Why is this default changing? That at least needs to be documented.
Contributor
Author
There was a problem hiding this comment.
Indeed, it shouldn't. Reverted.
mirceaulinic
force-pushed
the
napalm-junos-gate
branch
from
June 28, 2018 07:58
5a5dec1 to
f636dc7
Compare
mirceaulinic
force-pushed
the
napalm-junos-gate
branch
from
June 28, 2018 08:00
f636dc7 to
634f11e
Compare
rallytime
approved these changes
Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To gate functionality from the
junosExecution Module, by reusing theexisting connection from NAPALM.
At the same time, add two more handy functions that leverage the connection via the Netmiko module by reusing the connection arguments:
send_commandsandsend_config.