New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to utils/s3.py #48328

Merged
merged 2 commits into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@garethgreenaway
Member

garethgreenaway commented Jun 26, 2018

What does this PR do?

Need to pass the URL path through quote to ensure any special characters are being quoted properly. if we include local_file for a PUT, read the file into data before passing it along to requests.requests.

What issues does this PR fix or reference?

#48274

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@rallytime

This comment has been minimized.

garethgreenaway added some commits Jun 26, 2018

Need to pass the URL path through quote to ensure any special charact…
…ers are being quoted properly. if we include local_file for a PUT, read the file into data before passing it along to requests.requests.

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:48274_s3_get_signature_fail branch from d1e6b5d to 22cafc8 Jun 30, 2018

@rallytime rallytime merged commit 222c1d6 into saltstack:2018.3 Jul 2, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
default Pull Requests » Salt PR - Main Build - PY2/PY3 #9893
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11136 — ABORTED
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6166 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26377 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18414 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24094 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23049 — SUCCESS
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20219 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment