New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes fileserver maintenance process on Windows #48347

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
4 participants
@dwoz
Contributor

dwoz commented Jun 28, 2018

What does this PR do?

Fixes FileserverUpdate class so that the process starts on windows.

This will resolve errors which can be seen when the master starts up in windows kitchen tests:

12:55:48          File "<string>", line 1, in <module>
12:55:48          File "C:\Python35\lib\multiprocessing\spawn.py", line 106, in spawn_main
12:55:48            exitcode = _main(fd)
12:55:48          File "C:\Python35\lib\multiprocessing\spawn.py", line 116, in _main
12:55:48            self = pickle.load(from_parent)
12:55:48        EOFError: Ran out of input

Tests written?

No - Fixes existing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from saltstack/team-core as a code owner Jun 28, 2018

@dwoz dwoz requested review from s0undt3ch and gtmanfred Jun 28, 2018

@s0undt3ch

I don't have enough context to know better, If it works, it's good :)

@rallytime rallytime merged commit bbabbbf into saltstack:2018.3 Jun 28, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
default Pull Requests » Salt PR - Main Build - PY2/PY3 #9815
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11059 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20142 — ABORTED
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26293 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18339 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6089 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24017 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #22974 — SUCCESS
Details

@dwoz dwoz deleted the dwoz:sigfix branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment