Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco nxos proxy prompt fix #48378

merged 3 commits into from Jun 30, 2018


None yet
3 participants
Copy link

commented Jun 29, 2018

What does this PR do?

Makes it easier to execute commands that don't return a standard prompt--for example, firmware upgrades will ask for confirmation. The current setup just looks for <hostname>#.

What issues does this PR fix or reference?


Previous Behavior

The proxy would not recognize prompts other than <hostname>#

New Behavior

A new config option for this proxy was added called prompt_regex. This will be used in place of prompt_name if present. This is treated as a Python regular expression, and thus allows description of any prompt that can take the form of a regexp.

This new parameter is documented in the header docstring.

Tests written?


Commits signed with GPG?


cro added some commits Jun 28, 2018

Add a 'prompt_regexp' config variable that allows more customized res…

to potential prompts from the nxos cli.

This comment has been minimized.

Copy link

commented Jun 29, 2018

@cro looks like pylint doesn't like the \ in the docstring

probably just needs to make it a raw string with r

@rallytime rallytime merged commit ea90ff7 into saltstack:develop Jun 30, 2018

6 of 11 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
default Pull Requests » Salt PR - Main Build - PY2/PY3 #9875
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11116 — ABORTED
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20199 — ABORTED
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6146 — FAILURE
WIP ready for review
codeclimate All good!
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26352 — SUCCESS
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18396 — SUCCESS
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24074 — SUCCESS
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23031 — SUCCESS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.