Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Detect and preserve line endings #48380
What does this PR do?
Detects the line endings for the file and uses those to parse the file. Preserves the line endings when the file is written.
What issues does this PR fix or reference?
On Windows, files with Unix line endings were writing back an empty file.
Now the file is edited properly.
Commits signed with GPG?
referenced this pull request
Jul 2, 2018
It might be best if you just backport the change to 2017.7 instead of me trying to retrace your steps.
We'd probably still like to have some tests around this area, so if your tests are applicable to the new code, then please add them to your back-port PR.