Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[2017.7] fixes to module/file.py #48399
What does this PR do?
Setting the mode with setuid or setgid bits in addition to setting the owner and group will force the setuid & setgid bits to reset. This change ensures that we set the mode after setting the owner & group.
What issues does this PR fix or reference?
Setuid and setgid bits were wiped out with the chown action.
Chown is done last, preserving the chmod actions.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
@garethgreenaway Ah, there is a related test failing on the Ubuntu PY3 tests. Can you take a look?