New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tox to run pylint #48472

Merged
merged 2 commits into from Jul 7, 2018

Conversation

Projects
None yet
3 participants
@gtmanfred
Contributor

gtmanfred commented Jul 6, 2018

What does this PR do?

Also allow pylint to be run from a virtualenv

Commits signed with GPG?

Yes

use tox to run pylint
Also allow pylint to be run from a virtualenv

@salt-jenkins salt-jenkins requested a review from saltstack/team-netapi Jul 6, 2018

@dubb-b

dubb-b approved these changes Jul 6, 2018

OMG Yes!!!

@gtmanfred gtmanfred merged commit 22cd420 into saltstack:2017.7 Jul 7, 2018

5 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6276 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24204 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20329 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26488 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18522 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11246 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23158 — SUCCESS
Details
@KaiSforza

This comment has been minimized.

Contributor

KaiSforza commented Jul 9, 2018

@gtmanfred can we get this into the other branches?

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jul 9, 2018

@KaiSforza it will be merged forward when @rallytime does the merge forwards.

If you need it there now, then cherry pick it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment