New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #48476

Merged
merged 2 commits into from Jul 6, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Contributor

twangboy commented Jul 6, 2018

What does this PR do?

Adds back the libnacl dependency
Adds a note to req.txt to avoid dependency removal in the future
Adds back the libsodium.dll library
Adds a new dependency python-certifi-win32
Updates the licenses table

What issues does this PR fix or reference?

#45178
#46644
#48459

Tests written?

NA

Commits signed with GPG?

Yes

twangboy added some commits Jul 6, 2018

Fix dependencies
Adds back libnacl
Adds back libsodium.dll
Adds new python-certifi-win32

@twangboy twangboy requested a review from saltstack/team-windows Jul 6, 2018

@cachedout cachedout merged commit 27ea8f3 into saltstack:2017.7 Jul 6, 2018

4 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6279 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24207 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11249 — FAILURE
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20332 — RUNNING
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26491 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18525 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23161 — SUCCESS
Details

@twangboy twangboy deleted the twangboy:fix_dependencies branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment