New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cifixes #48490

Merged
merged 2 commits into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@KaiSforza
Contributor

KaiSforza commented Jul 9, 2018

What does this PR do?

Fixes up some of the issues with the PR builds in our lints

Previous Behavior

Lint tests wouldn't actually fail when they failed

All of the pr doc builds were archived

New Behavior

Any lint failures cause the lint job to fail

Doc builds aren't archived so we save space.

Tests written?

No

Commits signed with GPG?

Yes

KaiSforza added some commits Jul 9, 2018

Stop archiving the docs
This is just taking up space
@KaiSforza

This comment has been minimized.

Contributor

KaiSforza commented Jul 9, 2018

@dubb-b

dubb-b approved these changes Jul 9, 2018

@gtmanfred gtmanfred merged commit d38951b into saltstack:2017.7 Jul 9, 2018

2 of 11 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6294 — RUNNING
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24222 — RUNNING
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11264 — RUNNING
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23176 — RUNNING
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20347 — RUNNING
Details
jenkins/pr/docs Testing docs...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26506 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment