Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[2018.3] Fix 2 bugs found in the file.check_perms function #48508
What does this PR do?
This PR fixes 2 bugs found in the file.check_perms function.
What issues does this PR fix or reference?
In 2018.3, file attribute checks were added to file.check_perms and then the mode checks were moved down lower in the function. However, there is some logic to handle original comments where the list of comments is joined into a single string. There is also some logic to return
This logic is (correctly) at the bottom of the file.check_perms function in the 2017.7 branch.
This commit moves that logic back down to the bottom of the file.check_perms function for the 2018.3 branch.
We need this logic at the bottom of the function for the following reasons:
No - tests already written, which found this bug because it was failing.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.