New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback python-certifi-win32 #48526

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Contributor

twangboy commented Jul 11, 2018

What does this PR do?

Rolls back the python-certifi-win32 dependency addition. This has been causing some problems with the test suite. We need to look into this further before adding this dependency to see exactly how it's patching things.

What issues does this PR fix or reference?

#46644

Added in:
#48476

Tests written?

No

Commits signed with GPG?

Yes

Rollback python-certifi-win32
It's causing issues with the test suite on Windows

@twangboy twangboy requested review from dwoz and rallytime Jul 11, 2018

@dwoz

dwoz approved these changes Jul 11, 2018

@rallytime rallytime merged commit 05bad3e into saltstack:2017.7 Jul 11, 2018

6 of 11 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6360 — FAILURE
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24288 — RUNNING
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11330 — RUNNING
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20413 — RUNNING
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26572 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18605 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23241 — SUCCESS
Details
jenkins/pr/lint The lint job has passed
Details

@twangboy twangboy deleted the twangboy:rollback_certifi-win32 branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment