Enhancements to slack engine and wtmp beacon #48532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the following functionality: - `action` key added to the event data (either "login" or "logout") - Configurable ut_type to distinguish login and logout events (because hey, why the hell not) - Use of `__context__` to store user attached to a given tty so that we can report the user that logged out.
This uses the outputter from the raw return dict instead of hard-coding the highstate outputter for the state module and using yaml for everything else.
|
Changelog docs? |
|
Added. |
rallytime
approved these changes
Jul 12, 2018
doc/topics/releases/fluorine.rst
Outdated
| Enhancements to :py:mod:`wtmp <salt.beacons.wtmp>` Beacon | ||
| ========================================================= | ||
|
|
||
| A new key, `action`, has been added to the events fired by this beacon, which |
There was a problem hiding this comment.
Double backticks for code demarcation? :)
There's some other examples below that also need double backticks instead of single.
There was a problem hiding this comment.
Good catch. I have been writing a lot of markdown this week and my head was still in that mode. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
slackengine, the reuturn from commands spawned using the engine is now formatted using the engine specified in the raw return. Previously this would use the highstate outputter for all functions from thestatemodule, and the yaml outputter for everything else.For the
wtmpbeacon, the following was added:actionkey added to the event data (either "login" or "logout")__context__to store user attached to a given tty so that we can report the user that logged out.Additionally, the wtmp and btmp beacon docs have been modified to include a reactor use case for using the events that are fired by the beacons.