Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoremove, force-removal-of-dependent-packages for opkg.remove #48549

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

chotea
Copy link
Contributor

@chotea chotea commented Jul 12, 2018

What does this PR do?
This PR adds support for opkg remove in terms of giving the possibility of specifying two extra parameters: force-removal-of-dependent-packages, autoremove. It also contains unit tests for opkg module.

Previous Behavior
The implementation was always calling opkg remove without any extra parameters.

New Behavior
Now we check these 2 force-options in kwargs and append them to the command if necessary:

--force-removal-of-dependent-packages - Remove package and all dependencies
--autoremove - Remove packages that were installed automatically to
satisfy dependencies
Tests written?
Yes

Commits signed with GPG?
No

Old PR: #47240

@ghost ghost self-requested a review July 12, 2018 14:32
@chotea chotea force-pushed the extend_opkg_remove_support branch 2 times, most recently from 74e1423 to 715fe4a Compare July 13, 2018 09:09
Add extra options for opkg remove:
- --force-removal-of-dependent-packages - Remove package and all dependencies
- --autoremove - Remove packages that were installed automatically to
    satisfy dependencies
Add unit tests for opkg module

Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
@chotea chotea force-pushed the extend_opkg_remove_support branch from 715fe4a to 4391665 Compare July 13, 2018 10:12
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @chotea!

Thank you for this addition.

@rallytime rallytime merged commit 19548e8 into saltstack:develop Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants