Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoremove, force-removal-of-dependent-packages for opkg.remove #48549

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
2 participants
@chotea
Copy link
Contributor

commented Jul 12, 2018

What does this PR do?
This PR adds support for opkg remove in terms of giving the possibility of specifying two extra parameters: force-removal-of-dependent-packages, autoremove. It also contains unit tests for opkg module.

Previous Behavior
The implementation was always calling opkg remove without any extra parameters.

New Behavior
Now we check these 2 force-options in kwargs and append them to the command if necessary:

--force-removal-of-dependent-packages - Remove package and all dependencies
--autoremove - Remove packages that were installed automatically to
satisfy dependencies
Tests written?
Yes

Commits signed with GPG?
No

Old PR: #47240

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Jul 12, 2018

@chotea chotea force-pushed the chotea:extend_opkg_remove_support branch 2 times, most recently from 74e1423 to 715fe4a Jul 13, 2018

Add autoremove, force-removal-of-dependent-packages for opkg.remove
Add extra options for opkg remove:
- --force-removal-of-dependent-packages - Remove package and all dependencies
- --autoremove - Remove packages that were installed automatically to
    satisfy dependencies
Add unit tests for opkg module

Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>

@chotea chotea force-pushed the chotea:extend_opkg_remove_support branch from 715fe4a to 4391665 Jul 13, 2018

@rallytime
Copy link
Contributor

left a comment

This looks great @chotea!

Thank you for this addition.

@rallytime rallytime merged commit 19548e8 into saltstack:develop Jul 13, 2018

8 of 17 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #11403 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #20486 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #6433 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #24361 — FAILURE
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #26648 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #18678 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #23314 — SUCCESS
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.