Add autoremove, force-removal-of-dependent-packages for opkg.remove#48549
Merged
rallytime merged 1 commit intosaltstack:developfrom Jul 13, 2018
Merged
Add autoremove, force-removal-of-dependent-packages for opkg.remove#48549rallytime merged 1 commit intosaltstack:developfrom
rallytime merged 1 commit intosaltstack:developfrom
Conversation
ghost
self-requested a review
chotea
force-pushed
the
extend_opkg_remove_support
branch
2 times, most recently
from
74e1423 to
715fe4a
Compare
Add extra options for opkg remove:
- --force-removal-of-dependent-packages - Remove package and all dependencies
- --autoremove - Remove packages that were installed automatically to
satisfy dependencies
Add unit tests for opkg module
Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
chotea
force-pushed
the
extend_opkg_remove_support
branch
from
715fe4a to
4391665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for opkg remove in terms of giving the possibility of specifying two extra parameters: force-removal-of-dependent-packages, autoremove. It also contains unit tests for opkg module.
Previous Behavior
The implementation was always calling opkg remove without any extra parameters.
New Behavior
Now we check these 2 force-options in kwargs and append them to the command if necessary:
--force-removal-of-dependent-packages - Remove package and all dependencies
--autoremove - Remove packages that were installed automatically to
satisfy dependencies
Tests written?
Yes
Commits signed with GPG?
No
Old PR: #47240