New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] Fix service.disabled test for macosx #48664

Merged
merged 4 commits into from Jul 20, 2018

Conversation

Projects
None yet
2 participants
@Ch3LL
Contributor

Ch3LL commented Jul 18, 2018

What does this PR do?

similar to #48663 but don't need to add salt/modules/mac_service.py change

Fixes the test: integration.modules.test_service.ServiceModuleTest.test_service_disable_doesnot_exist

Failing with the following traceback:

Traceback (most recent call last):
  File "/testing/tests/integration/modules/test_service.py", line 123, in test_service_disable_doesnot_exist
    self.assertFalse(enable)
AssertionError: u'ERROR: Service not found: doesnotexist' is not false

Ch3LL added some commits Jul 18, 2018

@Ch3LL Ch3LL changed the title from [2017.7. to [2017.7] Fix service.disabled test for macosx Jul 18, 2018

Ch3LL added some commits Jul 19, 2018

@rallytime rallytime merged commit 1ebd96d into saltstack:2017.7 Jul 20, 2018

7 of 8 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment