New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac service.disable tests #48675

Merged
merged 1 commit into from Jul 20, 2018

Conversation

Projects
None yet
2 participants
@Ch3LL
Contributor

Ch3LL commented Jul 19, 2018

What does this PR do?

Since we are now accurately querying the disabled status of a service in macosx after this PR: #47578 we need to update this other mac service.disabled test to make sure we are disabling the service and not stopping it to determine if its disabled or not.

What issues does this PR fix or reference?

Fixes the failing test: integration.modules.test_mac_service.MacServiceModuleTest.test_disabled

Traceback (most recent call last):
  File "/testing/tests/support/helpers.py", line 122, in wrap
    return caller(cls)
  File "/testing/tests/integration/modules/test_mac_service.py", line 202, in test_disabled
    self.run_function('service.disabled', [SERVICE_NAME]))
AssertionError: False is not true

@rallytime rallytime merged commit 5f6a7c4 into saltstack:2017.7 Jul 20, 2018

5 of 6 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment