New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #48677 - return clean npm.bootstrap on no changes #48678

Merged
merged 1 commit into from Jul 20, 2018

Conversation

Projects
None yet
2 participants
@OrlandoArcapix
Contributor

OrlandoArcapix commented Jul 19, 2018

What does this PR do?

Returns a clean status when using npm.bootstrap in test mode with no changes to be made

What issues does this PR fix or reference?

#48677

Previous Behavior

test=true on npm.bootstrap state always returns "None"

New Behavior

Applying npm.bootstrap state with test=true returns "True" if no changes are flagged

Tests written?

No

Commits signed with GPG?

No

@rallytime rallytime merged commit 3e293b0 into saltstack:2017.7 Jul 20, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment