Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query current minion config with config.items #48681

Merged
merged 1 commit into from Jul 27, 2018

Conversation

@Arabus
Copy link
Contributor

@Arabus Arabus commented Jul 19, 2018

What does this PR do?

Adds an items function to the config execution module to query minions for their current running config.

What issues does this PR fix or reference?

Fixes #48680

Previous Behavior

The current running config could not be queried completely instead it hat to be cobbled together with config.get. This was cumbersome and required the caller to already know the item key name beforehand.

New Behavior

One can simply call salt '*' config.items to retrieve the current configuration of all minions.

Tests written?

No

Commits signed with GPG?

Yes

@rallytime rallytime requested a review from Jul 26, 2018
Copy link
Contributor

@DmitryKuzmenko DmitryKuzmenko left a comment

👍

@rallytime rallytime merged commit fe66023 into saltstack:develop Jul 27, 2018
5 of 9 checks passed
5 of 9 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
@wip[bot]
WIP ready for review
Details
codeclimate All good!
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
@rallytime
Copy link
Contributor

@rallytime rallytime commented Jul 27, 2018

Thanks @Arabus!

@Arabus Arabus deleted the add-config-items-function branch Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants