Add several new functions to the napalm module #48707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the functions required to gate functionality from the new Fluorine modules [``nxos_api``](https://docs.saltstack.com/en/develop/ref/modules/all/salt.modules.nxos_api.html) and [``pyeapi``](https://docs.saltstack.com/en/develop/ref/modules/all/salt.modules.arista_pyeapi.html). NAPALM has all the underlying dependencies for all of these modules, which is why we can reuse the code from the mentioned modules (plus ``junos``, ``netmiko`` etc.). This brings a lot of flexibility to the user, as without any further configuration (or very little for the non-native NAPALM drivers) can execute arbitrary RPC requests or show commands. This is due to the fact that the code also forwards the already existing configuration details. In other words, with this changes, starting with release Fluorine, NAPALM users will be able to execute commands such as: ``salt '*' napalm.pyeapi_run_commands 'show version'`` with no other changes in their environment. These functions are important as they open the gates to extend Salt without depending on the third party NAPALM library, which massively speeds up the development of new features (particularly when we need features that wouldn't have their place into the public NAPALM library).
cachedout
approved these changes
Jul 23, 2018
sagetherage
added
code-jam
Has Testcase
P1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the functions required to gate functionality from the new
Fluorine modules
nxos_apiand
pyeapi.NAPALM has all the underlying dependencies for all of these modules, which is
why we can reuse the code from the mentioned modules (plus
junos,netmikoetc.). This brings a lot of flexibility to the user, as without any further
configuration (or very little for the non-native NAPALM drivers) can execute
arbitrary RPC requests or show commands. This is due to the fact that the code
also forwards the already existing configuration details.
In other words, with this changes, starting with release Fluorine, NAPALM users
will be able to execute commands such as:
salt '*' napalm.pyeapi_run_commands 'show version'with no other changes intheir environment.
These functions are important as they open the gates to extend Salt without
depending on the third party NAPALM library, which massively speeds up the
development of new features (particularly when we need features that wouldn't
have their place into the public NAPALM library).
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Tests written?
Yes/No
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.