add salt cloud support for block device tagging or root devices and such#48716
add salt cloud support for block device tagging or root devices and such#48716rallytime merged 11 commits intosaltstack:developfrom
Conversation
ghost
self-requested a review
|
build kicked off before I committed the corrected code. |
|
@thetoolsmith Can you fix these lint errors? https://jenkinsci.saltstack.com/job/pr-lint/job/PR-48716/2/warnings52Result/ |
|
yeah, sorry about that. I pasted the code into the salt branch from my test system and missed the closing bracket. should have re-checked the code. |
rallytime
left a comment
rallytime
left a comment
There was a problem hiding this comment.
In addition to the inline requests, can you also document this new behavior?
Thanks @thetoolsmith!
| block_device_volume_id_map = {} | ||
|
|
||
| if ex_blockdevicetags: | ||
| for k, v in six.iteritems(ret['blockDeviceMapping']): |
There was a problem hiding this comment.
Can you switch these variables (and others below) to use 3 or more letters? That would be nice and match our Style Guide rules.
| transport=__opts__['transport'] | ||
| ) | ||
|
|
||
| salt.utils.cloud.wait_for_fun( |
There was a problem hiding this comment.
This can be the __utils__['cloud.x'] notation like you have above.
|
changes have been comitted |
3 participants
This pull request adds the ability to set block device tags in salt cloud configuration for root volumes and such.
Currently, it seems that this is not supported in salt-cloud.
ref: #47097
This change allows for configuration of block_device_mappings in cloud configuration to support a tag dictionary like so:
Tests written?
No
Commits signed with GPG?
No
Additional notes:
I also have another implementation that does not use the existing block_device_mappings configuration. Instead it would add a new cloud configuration block_device_tags. However, this change separates the mappings from the tags and might not be ideal.
I'm thinking this pr is the best approach, but will look for feedback from the core Salt team.
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.