New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_managed_source_hash_indifferent_case on macosx to correct tmp path #48720

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@Ch3LL
Contributor

Ch3LL commented Jul 23, 2018

The following test is failing on mac: integration.states.test_file.FileTest.test_managed_source_hash_indifferent_case with error:

Traceback (most recent call last):
  File "/testing/tests/integration/states/test_file.py", line 693, in test_managed_source_hash_indifferent_case
    assert ret[state_name]['result'] is True
KeyError: 'file_|-/tmp/salt-tests-tmpdir/source_hash_indifferent_case_|-/tmp/salt-tests-tmpdir/source_hash_indifferent_case_|-managed'

This is because mac's path is /private/tmp/....

Updating the test to use the name variable in the state_name

@rallytime rallytime merged commit ce4e222 into saltstack:2017.7 Jul 23, 2018

6 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment