New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test when syslog not available #48726

Merged
merged 1 commit into from Jul 24, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented Jul 24, 2018

What does this PR do?

Skip test when syslog not available (Python windows py2 does not have a syslog module)

https://jenkinsci.saltstack.com/job/2018.3/job/salt-windows-2016-py2/108/testReport/junit/unit.returners.test_syslog_return/SyslogReturnerTestCase/test_syslog_returner_unicode/

Tests written?

No - Fixing test

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from Ch3LL Jul 24, 2018

@Ch3LL

Ch3LL approved these changes Jul 24, 2018

@dwoz dwoz merged commit 04ab17a into saltstack:2018.3 Jul 24, 2018

6 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@dwoz dwoz deleted the dwoz:syslogtest branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment